omitempty

Signed-off-by: zirain <zirain2009@gmail.com>
envoyproxy · Apr 10, 2024 · c4ce09f · c4ce09f
1 parent 01de57e
commit c4ce09f
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/api/v1alpha1/accesslogging_types.go b/api/v1alpha1/accesslogging_types.go
@@ -100,7 +100,7 @@ type OpenTelemetryEnvoyProxyAccessLog struct {
 	// Deprecated: Use BackendRef instead.
 	//
 	// +optional
-	Host *string `json:"host"`
+	Host *string `json:"host,omitempty"`
 	// Port defines the port the extension service is exposed on.
 	// Deprecated: Use BackendRef instead.
 	//

diff --git a/api/v1alpha1/envoyproxy_metric_types.go b/api/v1alpha1/envoyproxy_metric_types.go
@@ -55,7 +55,7 @@ type ProxyOpenTelemetrySink struct {
 	// Deprecated: Use BackendRef instead.
 	//
 	// +optional
-	Host *string `json:"host"`
+	Host *string `json:"host,omitempty"`
 	// Port defines the port the service is exposed on.
 	// Deprecated: Use BackendRef instead.
 	//

diff --git a/api/v1alpha1/tracing_types.go b/api/v1alpha1/tracing_types.go
@@ -41,7 +41,7 @@ type TracingProvider struct {
 	// Deprecated: Use BackendRef instead.
 	//
 	// +optional
-	Host *string `json:"host"`
+	Host *string `json:"host,omitempty"`
 	// Port defines the port the provider service is exposed on.
 	// Deprecated: Use BackendRef instead.
 	//

diff --git a/internal/gatewayapi/testdata/envoyproxy-accesslog-backend.out.yaml b/internal/gatewayapi/testdata/envoyproxy-accesslog-backend.out.yaml
@@ -115,7 +115,6 @@ infraIR:
                     - name: otel-collector
                       namespace: monitoring
                       port: 4317
-                    host: null
                     resources:
                       k8s.cluster.name: cluster-1
                   type: OpenTelemetry