address comments and add missing test back

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
envoyproxy · Mar 14, 2024 · c4fae25 · c4fae25
1 parent 09749eb
commit c4fae25
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/internal/xds/translator/testdata/in/xds-ir/jsonpatch-missing-resource.yaml b/internal/xds/translator/testdata/in/xds-ir/jsonpatch-missing-resource.yaml
@@ -10,7 +10,7 @@ envoyPatchPolicies:
   namespace: "default"
   jsonPatches:
   - type: "type.googleapis.com/envoy.config.listener.v3.Listener"
-    name: "non-existant-listener"
+    name: "non-existing-listener"
     operation:
       op: "add"
       path: "/default_filter_chain/filters/0/typed_config/http_filters/0"

diff --git a/...nal/xds/translator/testdata/out/xds-ir/jsonpatch-missing-resource.envoypatchpolicies.yaml b/...nal/xds/translator/testdata/out/xds-ir/jsonpatch-missing-resource.envoypatchpolicies.yaml
@@ -9,7 +9,7 @@
         namespace: default
       conditions:
       - lastTransitionTime: null
-        message: 'Unable to find xds resources: type.googleapis.com/envoy.config.listener.v3.Listener/non-existant-listener'
+        message: 'Unable to find xds resources: type.googleapis.com/envoy.config.listener.v3.Listener/non-existing-listener'
         reason: ResourceNotFound
         status: "False"
         type: Programmed

diff --git a/internal/xds/translator/translator_test.go b/internal/xds/translator/translator_test.go
@@ -377,6 +377,9 @@ func TestTranslateXdsNegative(t *testing.T) {
 		{
 			name: "jsonpatch-invalid",
 		},
+		{
+			name: "jsonpatch-invalid-listener",
+		},
 		{
 			name: "accesslog-invalid",
 		},
-Original file line number
+Diff line change
@@ Expand Up / @@ -377,6 +377,9 @@ func TestTranslateXdsNegative(t *testing.T) { @@
     		{
     			name: "jsonpatch-invalid",
     		},
+    		{
+    			name: "jsonpatch-invalid-listener",
+    		},
     		{
     			name: "accesslog-invalid",
     		},
@@ Expand Down @@