Skip to content

Commit

Permalink
minor change to address a missing comment in #2944 (#2992)
Browse files Browse the repository at this point in the history
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
  • Loading branch information
zhaohuabing authored Mar 21, 2024
1 parent 37b0a48 commit c655811
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions internal/gatewayapi/securitypolicy.go
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,6 @@ func (t *Translator) translateSecurityPolicyForRoute(

if policy.Spec.OIDC != nil {
if oidc, err = t.buildOIDC(
irConfigName(policy),
policy,
resources); err != nil {
errs = errors.Join(errs, err)
Expand Down Expand Up @@ -454,7 +453,6 @@ func (t *Translator) translateSecurityPolicyForGateway(

if policy.Spec.OIDC != nil {
if oidc, err = t.buildOIDC(
irConfigName(policy),
policy,
resources); err != nil {
errs = errors.Join(errs, err)
Expand Down Expand Up @@ -588,7 +586,6 @@ func (t *Translator) buildJWT(jwt *egv1a1.JWT) *ir.JWT {
}

func (t *Translator) buildOIDC(
name string,
policy *egv1a1.SecurityPolicy,
resources *Resources) (*ir.OIDC, error) {
var (
Expand Down Expand Up @@ -662,7 +659,7 @@ func (t *Translator) buildOIDC(
}

return &ir.OIDC{
Name: name,
Name: irConfigName(policy),
Provider: *provider,
ClientID: oidc.ClientID,
ClientSecret: clientSecretBytes,
Expand Down

0 comments on commit c655811

Please sign in to comment.