fix: unique session name per route

Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
envoyproxy · Aug 7, 2024 · c91cfb6 · c91cfb6
1 parent 128817b
commit c91cfb6
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/internal/gatewayapi/route.go b/internal/gatewayapi/route.go
@@ -324,7 +324,10 @@ func (t *Translator) processHTTPRouteRule(httpRoute *HTTPRouteContext, ruleIdx i
 		if rule.SessionPersistence.SessionName == nil {
 			// SessionName is optional on the gateway-api, but envoy requires it
 			// so we generate the one here.
-			sessionName = "sticky-host"
+
+			// We generate a unique session name per route.
+			// `/` isn't allowed in the header key, so we just replace it with `-`.
+			sessionName = strings.ReplaceAll(irRouteDestinationName(httpRoute, ruleIdx), "/", "-")
 		} else {
 			sessionName = *rule.SessionPersistence.SessionName
 		}