Skip to content

Commit

Permalink
sort imports for envoy_shutdown and setup suite for merge-gateways
Browse files Browse the repository at this point in the history
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
  • Loading branch information
shawnh2 committed Apr 15, 2024
1 parent 6a32018 commit eb7629a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
//go:build e2e
// +build e2e

package e2e
package merge_gateways

Check failure on line 9 in test/e2e/merge_gateways/merge_gateways_test.go

View workflow job for this annotation

GitHub Actions / lint

ST1003: should not use underscores in package names (stylecheck)

import (
"flag"
Expand All @@ -18,7 +18,6 @@ import (
gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"
gwapiv1a2 "sigs.k8s.io/gateway-api/apis/v1alpha2"
"sigs.k8s.io/gateway-api/conformance/utils/flags"
"sigs.k8s.io/gateway-api/conformance/utils/kubernetes"
"sigs.k8s.io/gateway-api/conformance/utils/suite"

egv1a1 "github.com/envoyproxy/gateway/api/v1alpha1"
Expand Down Expand Up @@ -51,16 +50,11 @@ func TestMergeGateways(t *testing.T) {
GatewayClassName: *flags.GatewayClassName,
Debug: *flags.ShowDebug,
CleanupBaseResources: *flags.CleanupBaseResources,
FS: &e2e.Manifests,
RunTest: *flags.RunTest,
})

// Setting up the necessary arguments for the suite instead of calling Suite.Setup method again,
// since this test suite reuse the base resources of previous test suite.
cSuite.Applier.FS = e2e.Manifests
cSuite.Applier.GatewayClass = *flags.GatewayClassName
cSuite.ControllerName = kubernetes.GWCMustHaveAcceptedConditionTrue(t,
cSuite.Client, cSuite.TimeoutConfig, cSuite.GatewayClassName)

cSuite.Setup(t)
t.Logf("Running %d MergeGateways tests", len(tests.MergeGatewaysTests))
cSuite.Run(t, tests.MergeGatewaysTests)
}
11 changes: 4 additions & 7 deletions test/e2e/tests/envoy_shutdown.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,22 @@ import (
"testing"
"time"

"github.com/envoyproxy/gateway/api/v1alpha1"

"fortio.org/fortio/periodic"

"github.com/envoyproxy/gateway/internal/gatewayapi"
"github.com/envoyproxy/gateway/internal/infrastructure/kubernetes/proxy"

appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
v1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
"k8s.io/apimachinery/pkg/labels"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/wait"

"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/gateway-api/conformance/utils/config"
"sigs.k8s.io/gateway-api/conformance/utils/http"
"sigs.k8s.io/gateway-api/conformance/utils/kubernetes"
"sigs.k8s.io/gateway-api/conformance/utils/suite"

"github.com/envoyproxy/gateway/api/v1alpha1"
"github.com/envoyproxy/gateway/internal/gatewayapi"
"github.com/envoyproxy/gateway/internal/infrastructure/kubernetes/proxy"
)

func init() {
Expand Down

0 comments on commit eb7629a

Please sign in to comment.