Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E for the MergeGateways feature #2029

Closed
arkodg opened this issue Oct 20, 2023 · 4 comments · Fixed by #2665
Closed

Add E2E for the MergeGateways feature #2029

arkodg opened this issue Oct 20, 2023 · 4 comments · Fixed by #2665
Assignees
Labels
area/conformance Gateway API Conformance Related Issues area/testing road-to-ga
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Oct 20, 2023

Description:

Describe the issue.

Add an E2E in https://github.com/envoyproxy/gateway/tree/main/test/e2e for the MergeGateway features
Relates to #1938

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@arkodg arkodg added this to the 0.6.0 milestone Oct 20, 2023
@arkodg arkodg added area/conformance Gateway API Conformance Related Issues area/testing help wanted Extra attention is needed labels Oct 20, 2023
@arkodg arkodg modified the milestones: 0.6.0, Backlog Nov 2, 2023
@shawnh2 shawnh2 self-assigned this Nov 10, 2023
@shawnh2 shawnh2 removed the help wanted Extra attention is needed label Nov 10, 2023
@shawnh2
Copy link
Contributor

shawnh2 commented Nov 11, 2023

it seems a little tricky to implement this e2e test case.

our e2e test env deploys eg with controller name:

controllerName: gateway.envoyproxy.io/gatewayclass-controller

if we have mergeGateways feature enabled, it's better to create a new gatewayclass, not reuse the exist one:

apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
  name: eg-merge-gateways
spec:
  controllerName: gateway.envoyproxy.io/merge-gateways-controller  # needs another controller name
  parametersRef:
    group: gateway.envoyproxy.io
    kind: EnvoyProxy
    name: custom-proxy-config
    namespace: envoy-gateway-system
---
apiVersion: gateway.envoyproxy.io/v1alpha1
kind: EnvoyProxy
metadata:
  name: custom-proxy-config
  namespace: envoy-gateway-system
spec:
  mergeGateways: true  # enable

but that requires to deploy eg one more time, it's not worthy!

@arkodg
Copy link
Contributor Author

arkodg commented Nov 13, 2023

thanks for looking into this @shawnh2, maybe we can pause on this until #1231 is complete, which should make it easier to add and remove multiple gateway classes

Copy link

github-actions bot commented Jan 6, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

Copy link

github-actions bot commented Mar 9, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Mar 9, 2024
@arkodg arkodg modified the milestones: v1.0.0, v1.1.0-rc1 Mar 28, 2024
@github-actions github-actions bot removed the stale label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance Gateway API Conformance Related Issues area/testing road-to-ga
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants