fix: mergeGateways panics when restarting control plane #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2283 +/- ##
==========================================
- Coverage 64.38% 64.37% -0.01%
==========================================
Files 112 112
Lines 15874 15876 +2
==========================================
Hits 10220 10220
- Misses 5005 5007 +2
Partials 649 649 ☔ View full report in Codecov by Sentry. |
|
can you add a (e2e)test for this to avoid regression in the future? |
|
Can this be a follow up ? @zirain |
|
nop |
|
Okay, let me update it later |
|
I still think we can start working on e2e after #2029 (comment) let us fix the bug first @zirain |
zirain
previously approved these changes
Dec 13, 2023
zzjin
reviewed
Dec 13, 2023
|
Let me double check it before merging it. |
Xunzhuo
force-pushed
the
fix-mergeGateways-panics
branch
from
043e195 to
c7bf4fb
Compare
cnvergence
reviewed
Dec 13, 2023
cnvergence
reviewed
Dec 13, 2023
Xunzhuo
force-pushed
the
fix-mergeGateways-panics
branch
from
c7bf4fb to
37cc4a0
Compare
cnvergence
approved these changes
Dec 13, 2023
Signed-off-by: bitliu <bitliu@tencent.com>
Xunzhuo
force-pushed
the
fix-mergeGateways-panics
branch
from
37cc4a0 to
ce265c7
Compare
zirain
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2282