Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tab character in helm template #3153

Closed
networkhermit opened this issue Apr 9, 2024 · 2 comments
Closed

tab character in helm template #3153

networkhermit opened this issue Apr 9, 2024 · 2 comments
Assignees
@yigang01
Labels
area/installation good first issue Good for newcomers

Comments

@networkhermit
Copy link

Description:

I find that envoy-gateway-service.yaml contains a tab character, I believe it is added by accident.

gateway/charts/gateway-helm/templates/envoy-gateway-service.yaml

Line 14 in c943042

{{- .Values.deployment.ports | toYaml | nindent 2 -}}

@arkodg arkodg added good first issue Good for newcomers help wanted Extra attention is needed area/installation and removed triage labels Apr 9, 2024
@yigang01
Copy link
Contributor

yigang01 commented Apr 9, 2024

can you assign this to me @arkodg

@arkodg arkodg removed the help wanted Extra attention is needed label Apr 9, 2024
@yigang01 yigang01 mentioned this issue Apr 10, 2024
Merged
@shawnh2
Copy link
Contributor

shawnh2 commented Apr 16, 2024

closed in favor of #3169

@shawnh2 shawnh2 closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigang01 yigang01

Labels
area/installation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@arkodg @networkhermit @shawnh2 @yigang01