Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete tab character #3169

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix: delete tab character #3169

merged 2 commits into from
Apr 11, 2024

Conversation

yigang01
Copy link
Contributor

@yigang01 yigang01 commented Apr 10, 2024

fix:#3153

Signed-off-by: yigang01 <1769703801@qq.com>
@yigang01 yigang01 requested a review from a team as a code owner April 10, 2024 16:38
@shawnh2
Copy link
Contributor

shawnh2 commented Apr 11, 2024

/retest

@yigang01
Copy link
Contributor Author

/重新测试

/retest

May I ask how to operate it,again commit code?

@shahar-h
Copy link
Contributor

Proposal: you can add add a script that validates there are no tabs in chart yaml files by executing the following for each file:

grep -q $'\t' <yaml file>

This will prevent such cases in future.

@liorokman
Copy link
Contributor

This should have been caught by the yamllint tool. Maybe something is wrong with how it's being invoked as part of the build?

@zirain
Copy link
Contributor

zirain commented Apr 11, 2024

/retest

@zirain
Copy link
Contributor

zirain commented Apr 11, 2024

This should have been caught by the yamllint tool. Maybe something is wrong with how it's being invoked as part of the build?

why there's no difference in test/helm/default.yaml

@shahar-h
Copy link
Contributor

This should have been caught by the yamllint tool. Maybe something is wrong with how it's being invoked as part of the build?

That's because chart is ignored:

ignore: |
# This directory fails checks since many files
# are templated. Instead, we run the linter
# after running `make generate-manifests` which creates
# the Install YAML in bin/
charts/gateway-helm/

@liorokman
Copy link
Contributor

But the linter should still be run on the output of the template, after make generate-manifests is run.

@zirain
Copy link
Contributor

zirain commented Apr 11, 2024

This should have been caught by the yamllint tool. Maybe something is wrong with how it's being invoked as part of the build?

That's because chart is ignored:

ignore: |
# This directory fails checks since many files
# are templated. Instead, we run the linter
# after running `make generate-manifests` which creates
# the Install YAML in bin/
charts/gateway-helm/

there's a render result located test/helm/default.yaml, so I think helm will ignore that.
anyway it's fine to remove it.

@shahar-h
Copy link
Contributor

Right, but the output is generated correctly with space indentation.

@zirain zirain merged commit 0b761df into envoyproxy:main Apr 11, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants