Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ClientTrafficPolicy for TCP Listener #3163

Closed
shuji-2019 opened this issue Apr 10, 2024 · 3 comments · Fixed by #3337
Closed

Support ClientTrafficPolicy for TCP Listener #3163

shuji-2019 opened this issue Apr 10, 2024 · 3 comments · Fixed by #3337
Assignees
@aoledk
Labels
area/policy kind/feature new feature
Milestone
v1.1.0-rc1

Comments

@shuji-2019
Copy link

Description:

TCP Listener can't be configured with EnableProxyProtocol / IdleTimeout / ConnectionLimit / PerConnectionBufferLimit, but those fields are already available in ClientTrafficPolicy.

If ClientTrafficPolicy can be attached to TCP Listener, less EnvoyPatchPolicy will be used to extend EG.
@arkodg arkodg added help wanted Extra attention is needed and removed triage labels Apr 10, 2024
@arkodg arkodg modified the milestones: v1.1.0, v1.1.0-rc1 Apr 10, 2024
@bhamon bhamon mentioned this issue Apr 14, 2024
Closed
@aoledk
Copy link
Contributor

aoledk commented Apr 24, 2024 •
edited
Loading

@arkodg In community's plan, does this feature should be implemented after #1635 refactor is done.

If #1635 is needed, I can work on #1635, if not I can work on this feature.

@arkodg
Copy link
Contributor

arkodg commented Apr 24, 2024 •
edited
Loading

yeah we should probably wait on #1635, if you'd like to pick it up, go for it ! there's an existing WIP PR that may need some rebasing

This was referenced Apr 24, 2024
Closed
Merged
@aoledk
Copy link
Contributor

aoledk commented Apr 29, 2024

/assign

@aoledk aoledk mentioned this issue May 7, 2024
Merged
@shawnh2 shawnh2 added area/policy kind/feature new feature and removed help wanted Extra attention is needed labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aoledk aoledk

Labels
area/policy kind/feature new feature
Projects
None yet
Milestone
v1.1.0-rc1
Development

Successfully merging a pull request may close this issue.

feat(policy): Add CTP support for TCP/TLS listeners aoledk/gateway
4 participants
@aoledk @arkodg @shawnh2 @shuji-2019