feat(policy): Add CTP support for TCP/TLS listeners #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
|
/retest |
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
|
/retest |
arkodg
reviewed
May 15, 2024
| @@ -327,6 +324,14 @@ func validatePortOverlapForClientTrafficPolicy(l *ListenerContext, xds *ir.Xds, | |||
| } | |||
| } | |||
|
|
|||
| var tcpIR *ir.TCPListener | |||
There was a problem hiding this comment.
tcpIR is unused here, lets add it when needed ?
Signed-off-by: Dingkang Li <dingkang1743@gmail.com>
|
/retest |
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3337 +/- ##
==========================================
+ Coverage 67.41% 67.43% +0.02%
==========================================
Files 166 166
Lines 19186 19214 +28
==========================================
+ Hits 12934 12957 +23
- Misses 5322 5325 +3
- Partials 930 932 +2 ☔ View full report in Codecov by Sentry. |
|
@arkodg Do you think whether it's necessary to split this big PR to multiple small PRs for easier review ? Each small PR for single field in CTP. |
sorry for the delay in reviewing this one, on it ! |
arkodg
reviewed
May 22, 2024
zhaohuabing
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enable user to attach ClientTrafficPolicy 1 to TCP/TLS listeners, available fields are:
timeout(new field will be needed to specify tcp idle timeout in clientTimeout 2, raised in other issue feat: add support to configuring downstream idle timeout for TCP listener #3343)Which issue(s) this PR fixes:
Fixes #3163
Footnotes
https://gateway.envoyproxy.io/v1.0.1/api/extension_types/#clienttrafficpolicyspec ↩
https://gateway.envoyproxy.io/latest/api/extension_types/#clienttimeout ↩