-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: make kubectl patch commands use yaml instead of json payloads, for legibility #3180
Comments
big +1 |
i looks like the above example can be simplified slightly to: kubectl patch gateway eg --type=json --patch '
- op: add
path: "/spec/listeners/-"
value:
name: https
protocol: HTTPS
port: 443
tls:
mode: Terminate
certificateRefs:
- group: ""
kind: Secret
name: example-cert
' i'll use that format as the recipe to edit each instance. |
Maybe it would be better to execute after we redirect the results to a file, like the solution you started with: |
so for this issue the plan is to just translate the json to yaml. in a separate issue the idea is to provide two tabs, where one will just display the resource (or patch file) to apply, decoupled from the command that actually applies it. |
Signed-off-by: Eitan Suez <eitan@tetrate.io>
envoyproxy#3180) Signed-off-by: Eitan Suez <eitan@tetrate.io>
Signed-off-by: Eitan Suez <eitan@tetrate.io>
envoyproxy#3180) Signed-off-by: Eitan Suez <eitan@tetrate.io>
Signed-off-by: Eitan Suez <eitan@tetrate.io>
envoyproxy#3180) Signed-off-by: Eitan Suez <eitan@tetrate.io>
Signed-off-by: Eitan Suez <eitan@tetrate.io>
envoyproxy#3180) Signed-off-by: Eitan Suez <eitan@tetrate.io>
* docs: replaces json patch bodies with yaml format (#3180) Signed-off-by: Eitan Suez <eitan@tetrate.io> * docs: replaces json patch bodies with yaml format, in 'latest' version (#3180) Signed-off-by: Eitan Suez <eitan@tetrate.io> * docs - gateway address - removes auto-inserted prereqs anchor link Signed-off-by: Eitan Suez <eitan@tetrate.io> * docs - mutual tls - reverting edit of link to quickstart Signed-off-by: Eitan Suez <eitan@tetrate.io> --------- Signed-off-by: Eitan Suez <eitan@tetrate.io>
Description:
i wonder whether the
kubectl patch
commands used in different guides can be recast using yaml instead of json, to eliminate some of that noise.example:
https://gateway.envoyproxy.io/v1.0.1/tasks/security/basic-auth/#enable-https
becomes..
i'm not sure the yaml example above is the canonical way of using kubectl patch with yaml. i'll look more closely at that if this issue is accepted post-triage.
The text was updated successfully, but these errors were encountered: