docs: replaces json patch bodies with yaml format #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
changed the title
arkodg
reviewed
Apr 15, 2024
| @@ -29,7 +29,7 @@ Create a certificate and a private key for `www.example.com`: | |||
|
|
|||
| ```shell | |||
| openssl req -out www.example.com.csr -newkey rsa:2048 -nodes -keyout www.example.com.key -subj "/CN=www.example.com/O=example organization" | |||
| openssl x509 -req -days 365 -CA example.com.crt -CAkey example.com.key -set_serial 0 -in www.example.com.csr -out www.example.com.crt | |||
| openssl x509 -req -days 365 -CA ca.crt -CAkey ca.key -set_serial 0 -in www.example.com.csr -out www.example.com.crt | |||
eitansuez
force-pushed
the
docs-patch-yaml
branch
from
968f2b8 to
59ba74b
Compare
|
/retest |
shawnh2
reviewed
Apr 16, 2024
| @@ -5,6 +5,7 @@ title: "Gateway Address" | |||
| The Gateway API provides an optional [Addresses][] field through which Envoy Gateway can set addresses for Envoy Proxy Service. | |||
| Depending on the Service Type, the addresses of gateway can be used as: | |||
|
|
|||
| - [Prerequisites](#prerequisites) | |||
There was a problem hiding this comment.
do we need this in this context?
shawnh2
reviewed
Apr 16, 2024
|
|
||
| ## Prerequisites | ||
|
|
||
| - OpenSSL to generate TLS assets. | ||
|
|
||
| ## Installation | ||
|
|
||
| Follow the steps from the [Quickstart](../../quickstart) to install Envoy Gateway and the example manifest. | ||
| Follow the steps from the [Quickstart](../quickstart) to install Envoy Gateway and the example manifest. |
There was a problem hiding this comment.
this link should not be changed, it will lead to 404 pages
shawnh2
reviewed
Apr 16, 2024
| @@ -5,6 +5,7 @@ title: "Gateway Address" | |||
| The Gateway API provides an optional [Addresses][] field through which Envoy Gateway can set addresses for Envoy Proxy Service. | |||
| Depending on the Service Type, the addresses of gateway can be used as: | |||
|
|
|||
| - [Prerequisites](#prerequisites) | |||
shawnh2
reviewed
Apr 16, 2024
eitansuez
force-pushed
the
docs-patch-yaml
branch
from
59ba74b to
f467f93
Compare
|
/retest |
added 4 commits
April 17, 2024 09:26
Signed-off-by: Eitan Suez <eitan@tetrate.io>
envoyproxy#3180) Signed-off-by: Eitan Suez <eitan@tetrate.io>
Signed-off-by: Eitan Suez <eitan@tetrate.io>
Signed-off-by: Eitan Suez <eitan@tetrate.io>
eitansuez
force-pushed
the
docs-patch-yaml
branch
from
2b3dfc7 to
8849bca
Compare
|
i believe i have resolved all issues raised. if possible, please review and resolve those conversations. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
improves the docs.
Which issue(s) this PR fixes:
Fixes #3180