Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egctl x translate should be able to process multiple gatewayclasses #3207

Open
shawnh2 opened this issue Apr 16, 2024 · 2 comments · May be fixed by #3960
Open

egctl x translate should be able to process multiple gatewayclasses #3207

shawnh2 opened this issue Apr 16, 2024 · 2 comments · May be fixed by #3960

Comments

@shawnh2
Copy link
Contributor

shawnh2 commented Apr 16, 2024

Description:

For now, the kubernetesYAMLToResources function in egctl x translate only able to process one GatewayClass, for multiple GC case, the translation will fail.

func kubernetesYAMLToResources(str string, addMissingResources bool) (*gatewayapi.Resources, error) {

IMO, above function should return something like:

type LoadResources struct {
        Resources
        
        GatewayClasses  []*gwv1.GatewayClass
        EnvoyProxies    []*egv1a1.EnvoyProxy
}
  • The GC and EP should be stored in list instead of variable
  • Above function should be placed in gatewayapi layer (This will be super helpful for file-provider in standalone mode to reuse this logic to load all kinds of resources from file)

Any thoughts on this? cc @envoyproxy/gateway-maintainers

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@shawnh2
Copy link
Contributor Author

shawnh2 commented May 16, 2024

will get to #1295 before resolving this one

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant