-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting to override default request timeout #3251
Comments
there's a lot of timeout in envoy, which one? |
we currently set the rule in the httproute
But this is for the full request if I understand. Getting a lot of up stream timeout errors with out this being set So ideally it would be the response timeout we would like to alter globally as we have some services which can take over 10seconds So I assume it a global route timeout that is required |
Hi @owenhaynes. The timeout that you're referring to in the Gateway API HTTP Route is implemented in EG as Envoy's route timeout: https://www.envoyproxy.io/docs/envoy/latest/faq/configuration/timeouts#route-timeouts. I'm not familiar with an equivalent global Envoy setting. One thing that can be done here to improve UX is to additionally support this timeout value in EG's ClientTrafficPolicy. Then, you can attach a policy to Gateway, which will make this timeout apply to all routes attached to that gateway. However, since this creates overlap with existing Gateway-API config, perhaps the best approach is to raise this requirement in Gateway-API. |
Yeah I don' think envoy has a global setting for this as a question got asked in the https://groups.google.com/g/envoy-users/c/Bbp3SNLIw8Y I like the concept of doing this at a ClientTrafficPolicy but this is not great when merge gateways are used as at a platform level we have no control. So maybe the EnvoyProxy resource is a better place. I mean we could add a Kyverno mutation to fix this but that's asking for trouble 😄. I do like the idea of it being added to the Gateway-API but that is slow moving |
EnvoyPatchPolicy is also an option that you can consider here. It supports GatewayClass attachment for the MergeGateways scenario that you describe: https://gateway.envoyproxy.io/v1.0.1/tasks/extensibility/envoy-patch-policy/. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. |
I got this issue when trying to perform long-running gRPC server stream (>15s). Try to use patch policy but still unlucky |
looks like this was asked in slack recently as well https://envoyproxy.slack.com/archives/C03E6NHLESV/p1717439123191249 |
@galihputera if you are looking at setting request timeouts at the route level, these examples https://gateway.envoyproxy.io/v1.0.1/tasks/traffic/http-timeouts/ should help |
Thanks, @arkodg but I'm asking about the timeout by using grpcroute resource https://gateway.envoyproxy.io/v1.0.1/tasks/traffic/grpc-routing/ seems there is no configuration there yet. We want to enable the grpc-web feature |
I'm proposing adding the
wdyt @envoyproxy/gateway-maintainers |
+1 for adding Just one small question: if we apply |
ah good point, |
+1 for adding requestTimeout in BTP. |
Picking it up. /assign |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. |
(No worries, it's not slipped from my list. It's just that my OSS capacity is overwhelmed on k/k side at the moment...) |
np @sanposhiho, we have about a month for the v1.2.0 release |
Description:
The default timeout looks to be 10seconds we would like to easily be able to change this globally to 30 seconds. It maybe possible to do this with envoy config patching but this seems overly complicated for a simple change.
The text was updated successfully, but these errors were encountered: