Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement RequestTimeout in BackendTrafficPolicy #4329

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

sanposhiho
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

implement RequestTimeout in BackendTrafficPolicy

Which issue(s) this PR fixes:

Fixes #3251

@sanposhiho sanposhiho requested a review from a team as a code owner September 25, 2024 04:16
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.75%. Comparing base (9565863) to head (32f9203).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/clustersettings.go 76.92% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4329      +/-   ##
==========================================
- Coverage   65.77%   65.75%   -0.02%     
==========================================
  Files         200      200              
  Lines       24141    24149       +8     
==========================================
+ Hits        15878    15879       +1     
- Misses       7133     7136       +3     
- Partials     1130     1134       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkodg
arkodg previously approved these changes Oct 8, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team October 8, 2024 03:37
@arkodg
Copy link
Contributor

arkodg commented Oct 8, 2024

hey can you run make generate and commit those changes ?

@sanposhiho
Copy link
Contributor Author

oops, done 🙏

@arkodg
Copy link
Contributor

arkodg commented Oct 10, 2024

can you re run make generate and commit those changes @sanposhiho , looks like you will not be able to add a custom comment like # Overwritten by the request timeout in HTTPRoute since it breaks the test generation check

@sanposhiho
Copy link
Contributor Author

Well, I ran make manifests and solved some parts of the CI failure. But, looks like I still need to run something else additionally.

Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
@sanposhiho
Copy link
Contributor Author

@arkodg Now it's fixed! (looks like I needed rebase + make manifests)

@arkodg arkodg requested review from a team October 15, 2024 22:27
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkodg arkodg merged commit 5880d6b into envoyproxy:main Oct 15, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting to override default request timeout
3 participants