-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement RequestTimeout in BackendTrafficPolicy #4329
Conversation
42e3228
to
9214d8d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4329 +/- ##
==========================================
- Coverage 65.77% 65.75% -0.02%
==========================================
Files 200 200
Lines 24141 24149 +8
==========================================
+ Hits 15878 15879 +1
- Misses 7133 7136 +3
- Partials 1130 1134 +4 ☔ View full report in Codecov by Sentry. |
cb80c44
to
087d441
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
hey can you run |
oops, done 🙏 |
c429715
to
108f9f5
Compare
can you re run |
108f9f5
to
f748624
Compare
Well, I ran |
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
Signed-off-by: Kensei Nakada <handbomusic@gmail.com>
f748624
to
32f9203
Compare
@arkodg Now it's fixed! (looks like I needed rebase + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What this PR does / why we need it:
implement RequestTimeout in BackendTrafficPolicy
Which issue(s) this PR fixes:
Fixes #3251