-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
egctl: implement config envoy-proxy all
command
#1060
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1060 +/- ##
==========================================
- Coverage 64.33% 63.73% -0.61%
==========================================
Files 70 71 +1
Lines 9012 9248 +236
==========================================
+ Hits 5798 5894 +96
- Misses 2820 2948 +128
- Partials 394 406 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
shouldnt the title be |
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
config all
commandconfig envoy-proxy all
command
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: zirain <hejianpeng2@huawei.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: zirain <hejianpeng2@huawei.com>
Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
thanks @zirain this looks like a great start, hoping you can add some test cases since the current diff coverage for this PR is 0% |
@@ -12,3 +12,4 @@ | |||
go.mod | |||
go.sum | |||
bin | |||
testdata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't right, we were linting testdata
earlier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me ignore special file, configdump file will not pass codespell check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled in your branch and deleted the tracer
that was causing the issue
diff --git a/internal/cmd/egctl/testdata/config/out.json b/internal/cmd/egctl/testdata/config/out.json
index d7bc3d3..1bd6f16 100644
--- a/internal/cmd/egctl/testdata/config/out.json
+++ b/internal/cmd/egctl/testdata/config/out.json
@@ -1316,10 +1316,6 @@
"envoy.extensions.filters.network.thrift_proxy.router.v3.Router"
]
},
- {
- "name": "envoy.dynamic.ot",
- "category": "envoy.tracers"
- },
this fixed codespell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zirain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks !
xref: #915