Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bootstrap/listener/cluster/route configdump support #1083

Merged
merged 3 commits into from
Feb 28, 2023
Merged

feat: add bootstrap/listener/cluster/route configdump support #1083

merged 3 commits into from
Feb 28, 2023

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Feb 28, 2023

xref: #915

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #1083 (9b91dd7) into main (7a373cc) will decrease coverage by 1.64%.
The diff coverage is 11.53%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
- Coverage   63.71%   62.07%   -1.64%     
==========================================
  Files          71       72       +1     
  Lines        9223     9473     +250     
==========================================
+ Hits         5876     5880       +4     
- Misses       2943     3187     +244     
- Partials      404      406       +2
Impacted Files Coverage Δ
internal/cmd/egctl/config.go 4.40% <2.38%> (-5.85%) ⬇️
internal/cmd/egctl/translate.go 67.96% <55.55%> (+0.38%) ⬆️
internal/cmd/egctl/utils.go 88.00% <88.00%> (ø)
internal/provider/kubernetes/helpers.go 81.08% <0.00%> (-2.71%) ⬇️
internal/provider/kubernetes/controller.go 50.22% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Xunzhuo Xunzhuo force-pushed the feat-cd branch 6 times, most recently from a98e065 to 0a2e1ea Compare February 28, 2023 08:32
@Xunzhuo
feat: add listener/cluster/route configdump support
9b91dd7 
Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo changed the title feat: add listener/cluster/route configdump support feat: add bootstrap/listener/cluster/route configdump support Feb 28, 2023
@Xunzhuo Xunzhuo marked this pull request as ready for review February 28, 2023 08:36
@Xunzhuo Xunzhuo requested a review from a team as a code owner February 28, 2023 08:36
@Xunzhuo Xunzhuo requested a review from zirain February 28, 2023 08:36
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Feb 28, 2023

cc @zirain

@Xunzhuo Xunzhuo requested a review from zirain February 28, 2023 08:53
@Xunzhuo
update
8e48864 
Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Feb 28, 2023

Done @zirain, PTAL.

@Xunzhuo Xunzhuo added area/config Issues related to config management, e.g. Config Manager, Config Sources, etc. area/egctl labels Feb 28, 2023
@Xunzhuo Xunzhuo added this to the 0.4.0-rc.1 milestone Feb 28, 2023
@Xunzhuo
update
72ffbab 
Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo requested a review from zirain February 28, 2023 11:24
zirain
zirain approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zirain zirain merged commit a23cd3e into envoyproxy:main Feb 28, 2023
@Xunzhuo Xunzhuo deleted the feat-cd branch February 28, 2023 12:28
@zirain zirain mentioned this pull request Feb 28, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zirain zirain zirain approved these changes

Assignees
No one assigned
Labels
area/config Issues related to config management, e.g. Config Manager, Config Sources, etc. area/egctl
Projects
None yet
Milestone
0.4.0-rc.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Xunzhuo @codecov-commenter @zirain