feat(infrastructure/proxy): add readiness probes in envoy proxy deployments #1568
Conversation
This commit adds readiness probes in envoy proxy deployments to prevent pods in not ready state to receive traffic. This allows envoy proxy configurations and in-place upgrades without traffic drops using the configured rollout strategy. Signed-off-by: Pratyush Singhal <psinghal20@gmail.com>
…ootstrap config Signed-off-by: Pratyush Singhal <psinghal20@gmail.com>
Signed-off-by: Pratyush Singhal <psinghal20@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1568 +/- ##
==========================================
+ Coverage 61.73% 61.84% +0.10%
==========================================
Files 81 81
Lines 12182 12190 +8
==========================================
+ Hits 7521 7539 +18
+ Misses 4191 4182 -9
+ Partials 470 469 -1
|
| address: {{ .ReadyServer.Address }} | ||
| port_value: {{ .ReadyServer.Port }} | ||
| protocol: TCP | ||
| filter_chains: |
There was a problem hiding this comment.
lets also add a text based access log that outputs to stdout https://github.com/envoyproxy/gateway/blob/75e7ada61fe1db9455481f2321309e099f3d8977/internal/xds/translator/listener.go#LL57C19-L57C19
There was a problem hiding this comment.
as well as the per connection setting
There was a problem hiding this comment.
yeah understand where you are coming from, its fine to leave it as is. My reasoning for adding it was from a correctness/visibility perspective where user wants to exactly know what requests are being made to the proxy to better correlate cpu/system consumption etc.
There was a problem hiding this comment.
@psinghal20 can you incorporate the PerConnectionBufferLimitBytes setting into the config, to reduce buffer space, tia !
What type of PR is this?
This PR adds readiness probes in envoy proxy deployments to prevent pods in a not-ready state to receive traffic.
What this PR does / why we need it:
This allows envoy proxy configurations and in-place upgrades without traffic drops using the configured rollout strategy.
Which issue(s) this PR fixes:
Fixes #1567
To access the admin APIs through the readiness probe, I had to change the listener admin address to
0.0.0.0from127.0.0.1to allow the envoy to listen on other network interfaces as well. Let me know if this needs to be changed.