-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add experimental conformance support #1780
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1780 +/- ##
==========================================
+ Coverage 65.32% 65.35% +0.02%
==========================================
Files 86 86
Lines 12529 12529
==========================================
+ Hits 8185 8188 +3
+ Misses 3826 3824 -2
+ Partials 518 517 -1 |
thanks for working on this @Xunzhuo ! |
da6ca58
to
d8b1e37
Compare
|
I think experimental conformance can run in main CI, and having conformance report in every commit.
I think each time we bump gwapi version ? |
should we only run & publish this every time we import a new gateway api version ? |
Sounds good : ) |
b104778
to
4888ace
Compare
4888ace
to
ab21a9b
Compare
ab21a9b
to
2204b2c
Compare
I tested and made changes to gwapi.yaml, https://github.com/envoyproxy/gateway/actions/runs/6117087341?pr=1780, it worked normally. |
|
||
jobs: | ||
experimental-conformance-test: | ||
permissions: write-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any way to descope this a bit ?
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
29afd04
to
df89a88
Compare
Debug: *flags.ShowDebug, | ||
CleanupBaseResources: *flags.CleanupBaseResources, | ||
SkipTests: skipTests, | ||
SupportedFeatures: sets.Set[suite.SupportedFeature]{}.Insert(suite.HTTPRouteExtendedFeatures.UnsortedList()...), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably want to add a lot more https://github.com/kubernetes-sigs/gateway-api/blob/8ab4e18ca73533793f8a5d4e8c4248626b4690bf/conformance/utils/suite/features.go#L195
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding another great tool to EG @Xunzhuo !
minor comment which can be done as a follow up
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes: