feat: Multiple RequestMirrors Filters per HTTPRoute Rule #1819
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -456,7 +456,7 @@ var ( | |
| PathMatch: &StringMatch{ | ||
| Exact: ptrTo("mirrorfilter"), | ||
| }, | ||
| Mirror: []*RouteDestination{&happyRouteDestination}, | ||
| } | ||
|
|
||
| // RouteDestination | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,7 +45,7 @@ | |
| case httpRoute.URLRewrite != nil: | ||
| routeAction := buildXdsURLRewriteAction(httpRoute.Destination.Name, httpRoute.URLRewrite) | ||
| if httpRoute.Mirror != nil { | ||
| routeAction.RequestMirrorPolicies = buildXdsRequestMirrorPolicies(httpRoute.Mirror) | ||
| } | ||
|
|
||
| router.Action = &routev3.Route_Route{Route: routeAction} | ||
|
|
@@ -54,13 +54,13 @@ | |
| // If there are invalid backends then a weighted cluster is required for the route | ||
| routeAction := buildXdsWeightedRouteAction(httpRoute) | ||
| if httpRoute.Mirror != nil { | ||
| routeAction.RequestMirrorPolicies = buildXdsRequestMirrorPolicies(httpRoute.Mirror) | ||
| } | ||
| router.Action = &routev3.Route_Route{Route: routeAction} | ||
| } else { | ||
| routeAction := buildXdsRouteAction(httpRoute.Destination.Name) | ||
| if httpRoute.Mirror != nil { | ||
| routeAction.RequestMirrorPolicies = buildXdsRequestMirrorPolicies(httpRoute.Mirror) | ||
| } | ||
| router.Action = &routev3.Route_Route{Route: routeAction} | ||
| } | ||
|
|
@@ -293,11 +293,13 @@ | |
| return routeAction | ||
| } | ||
|
|
||
| func buildXdsRequestMirrorPolicies(mirrorDestinations []*ir.RouteDestination) []*routev3.RouteAction_RequestMirrorPolicy { | ||
| var mirrorPolicies []*routev3.RouteAction_RequestMirrorPolicy | ||
|
|
||
| for _, mirrorDest := range mirrorDestinations { | ||
| mirrorPolicies = append(mirrorPolicies, &routev3.RouteAction_RequestMirrorPolicy{ | ||
| Cluster: mirrorDest.Name, | ||
| }) | ||
| } | ||
|
|
||
| return mirrorPolicies | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,10 @@ http: | |
| endpoints: | ||
| - host: "1.2.3.4" | ||
| port: 50000 | ||
| mirrors: | ||
|
There was a problem hiding this comment. lets keep this example as is, and create one more test file for multiple-mirrors ? There was a problem hiding this comment. Sound good, will do. |
||
| - name: "mirror-route-dest" | ||
| endpoints: | ||
| - host: "2.3.4.5" | ||
| - name: "mirror-route-dest1" | ||
| endpoints: | ||
| - host: "3.4.5.6" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,3 +24,16 @@ | |
| outlierDetection: {} | ||
| perConnectionBufferLimitBytes: 32768 | ||
| type: EDS | ||
| - commonLbConfig: | ||
| localityWeightedLbConfig: {} | ||
| connectTimeout: 10s | ||
| dnsLookupFamily: V4_ONLY | ||
| edsClusterConfig: | ||
| edsConfig: | ||
| ads: {} | ||
| resourceApiVersion: V3 | ||
| serviceName: mirror-route-dest1 | ||
| name: mirror-route-dest1 | ||
| outlierDetection: {} | ||
| perConnectionBufferLimitBytes: 32768 | ||
| type: EDS | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,3 +18,13 @@ | |
| portValue: 0 | ||
| loadBalancingWeight: 1 | ||
| locality: {} | ||
| - clusterName: mirror-route-dest1 | ||
| endpoints: | ||
| - lbEndpoints: | ||
| - endpoint: | ||
| address: | ||
| socketAddress: | ||
| address: 3.4.5.6 | ||
| portValue: 0 | ||
| loadBalancingWeight: 1 | ||
| locality: {} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,3 +12,4 @@ | |
| cluster: route-dest | ||
| requestMirrorPolicies: | ||
| - cluster: mirror-route-dest | ||
| - cluster: mirror-route-dest1 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -201,14 +201,16 @@ | |
| } | ||
|
|
||
| if httpRoute.Mirror != nil { | ||
| for _, mirrorDest := range httpRoute.Mirror { | ||
| if err := addXdsCluster(tCtx, addXdsClusterArgs{ | ||
| name: mirrorDest.Name, | ||
| endpoints: mirrorDest.Endpoints, | ||
| tSocket: nil, | ||
| protocol: protocol, | ||
| endpointType: Static, | ||
| }); err != nil && !errors.Is(err, ErrXdsClusterExists) { | ||
| return err | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just use i
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can use 'i' if I don't need to match the value with the index of Mirror list.