fix: prevent nil pointer panic because of nonexist attribute of Access Log

[ardikabs]

Fixes #1830
Additionally, I also added a test for JSON format type Access Log.

[codecov]

Codecov Report

Merging #1838 (9f74d04) into main (f31fbaa) will increase coverage by 0.30%.
The diff coverage is 71.73%.

@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
+ Coverage   65.06%   65.36%   +0.30%     
==========================================
  Files          86       86              
  Lines       12480    12526      +46     
==========================================
+ Hits         8120     8188      +68     
+ Misses       3838     3821      -17     
+ Partials      522      517       -5     

Files Changed	Coverage Δ
api/config/v1alpha1/validation/validate.go	73.38% <70.45%> (-1.36%)	⬇️
internal/gatewayapi/listener.go	97.68% <100.00%> (+6.45%)	⬆️

... and 2 files with indirect coverage changes

[Xunzhuo]

Plz run make testdata and submit again, thanks.

[arkodg]

imo this should be handled in

gateway/api/config/v1alpha1/validation/validate.go

Line 40 in 3999cdd

func validateEnvoyProxySpec(spec *egcfgv1a1.EnvoyProxySpec) error {

and we must error out early if type: File has a nil , file field, this will be caught in the provider layer which reconciles the resource and the error will surface in the GatewayClass status condition

[ardikabs]

imo this should be handled in

gateway/api/config/v1alpha1/validation/validate.go

Line 40 in 3999cdd

func validateEnvoyProxySpec(spec *egcfgv1a1.EnvoyProxySpec) error {

and we must error out early if type: File has a nil , file field, this will be caught in the provider layer which reconciles the resource and the error will surface in the GatewayClass status condition

but @arkodg , as per the docs, it said, it is expected to disable the access log for type: File if path was not defined or empty. So, it seems to me adding an error to the gatewayclass status would against with the docs, wdyt?

[arkodg]

oh good catch @ardikabs , I think that is a docs error. we have a field called disable to disable access logs now, let me fix that https://gateway.envoyproxy.io/v0.5.0/api/config_types.html#proxyaccesslog

[arkodg]

raised #1850 to fix doc string discrepancy.

[ardikabs]

hi @arkodg, I've added additional validation to error out early regarding Access Log on EnvoyProxy.