Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix incorrect item number in accesslog design doc #1854

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Aug 31, 2023

What type of PR is this?

docs: typo fix

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner August 31, 2023 06:36
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1854 (138b2c3) into main (a0769d6) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head 138b2c3 differs from pull request most recent head 572984b. Consider uploading reports for the commit 572984b to get more accurate results

@@            Coverage Diff             @@
##             main    #1854      +/-   ##
==========================================
- Coverage   65.39%   65.21%   -0.19%     
==========================================
  Files          86       86              
  Lines       12526    12480      -46     
==========================================
- Hits         8192     8139      -53     
- Misses       3818     3823       +5     
- Partials      516      518       +2     

see 4 files with indirect coverage changes

Copy link
Contributor

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worked as expected.

The result is same, but it's more easy to insert a paragraph in the middle.

@zirain
Copy link
Contributor

zirain commented Aug 31, 2023

actually, should change 2. to 1.

@shawnh2
Copy link
Contributor Author

shawnh2 commented Aug 31, 2023

It's worked as expected.

The result is same, but it's more easy to insert a paragraph in the middle.

in that case, would the unordered list be great?

Signed-off-by: sh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from zirain August 31, 2023 09:09
@Xunzhuo Xunzhuo merged commit cc5be74 into envoyproxy:main Sep 5, 2023
7 checks passed
@shawnh2 shawnh2 deleted the accesslog-design-doc branch September 5, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants