Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics(virtualHosts): add support for opt-in virtual host metrics stats #1855

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

psinghal20
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
This PR adds support for enabling virtual host metrics stats by adding the virtual cluster configuration.

There is an API change in the EnvoyProxy spec with the addition of EnableVirtualHostStats in the Telemetry.Metrics configuration.

I have added a unit test for translation and xdsIR generation.

Which issue(s) this PR fixes:

Fixes #1822

Signed-off-by: Pratyush Singhal <psinghal20@gmail.com>
@psinghal20 psinghal20 requested a review from a team as a code owner August 31, 2023 12:40
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1855 (60a9652) into main (a324513) will increase coverage by 0.01%.
The diff coverage is 67.44%.

@@            Coverage Diff             @@
##             main    #1855      +/-   ##
==========================================
+ Coverage   65.24%   65.25%   +0.01%     
==========================================
  Files          86       86              
  Lines       12480    12520      +40     
==========================================
+ Hits         8142     8170      +28     
- Misses       3821     3832      +11     
- Partials      517      518       +1     
Files Changed Coverage Δ
internal/ir/xds.go 73.60% <ø> (ø)
internal/ir/zz_generated.deepcopy.go 13.54% <0.00%> (-0.25%) ⬇️
internal/gatewayapi/listener.go 91.62% <100.00%> (+0.39%) ⬆️
internal/xds/translator/translator.go 79.85% <100.00%> (+1.36%) ⬆️

... and 2 files with indirect coverage changes

…configuration

Signed-off-by: Pratyush Singhal <psinghal20@gmail.com>
Signed-off-by: Pratyush Singhal <psinghal20@gmail.com>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @psinghal20 !

@Alice-Lilith Alice-Lilith merged commit 4e5b1ce into envoyproxy:main Sep 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opt in to per Hostname metrics
3 participants