Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix: follow-up of #1852 #1869

Merged
merged 2 commits into from
Sep 6, 2023
Merged

🐛 Fix: follow-up of #1852 #1869

merged 2 commits into from
Sep 6, 2023

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Sep 6, 2023

What type of PR is this?

What this PR does / why we need it:

  • Add missing index
  • Set EnvoyProxy Service Type to ClusterIP, since LoadBalancer is not supported in default submariner env.
  • Upgrade RG to v1beta1.

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo requested a review from a team as a code owner September 6, 2023 02:23
@Xunzhuo Xunzhuo requested review from a team, kflynn, zhaohuabing and qicz and removed request for a team September 6, 2023 02:23
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #1869 (fedf933) into main (1fab508) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1869      +/-   ##
==========================================
- Coverage   65.35%   65.31%   -0.04%     
==========================================
  Files          86       86              
  Lines       12526    12526              
==========================================
- Hits         8186     8181       -5     
- Misses       3823     3826       +3     
- Partials      517      519       +2     

see 2 files with indirect coverage changes

zirain
zirain previously approved these changes Sep 6, 2023
Signed-off-by: bitliu <bitliu@tencent.com>
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning up!

@zirain zirain merged commit 2e6211a into envoyproxy:main Sep 6, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants