Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add user guide for Gateway API State Metrics #1871

Merged

Conversation

david-martin
Copy link
Contributor

What type of PR is this?

Docs, new user guide

What this PR does / why we need it:

This PR adds a new User Guide for installing and using Gateway API State Metrics (metrics, dashboards and alerts).

Which issue(s) this PR fixes:

Fixes #1823

@david-martin david-martin requested a review from a team as a code owner September 7, 2023 08:57
@david-martin david-martin force-pushed the gateway-api-state-metrics-guide branch 3 times, most recently from 75f4bbe to 0ffc6c2 Compare September 7, 2023 10:01
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it, did not test it yet, raise a quesion here.

Once Kustomize is installed, run the following commands to install the metrics stack, with the Gateway API State Metrics configuration, on your kubernetes cluster.

```shell
kustomize build github.com/kuadrant/gateway-api-state-metrics.git/examples/kube-prometheus | docker run --rm -i ryane/kfilt -i kind=CustomResourceDefinition | kubectl apply --server-side -f -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to release the yaml in upstream, so that people can use it easier

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Xunzhuo
Do you mean avoid using kustomize, or something else?

Copy link
Member

@Xunzhuo Xunzhuo Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.
I'll use the kustomize cmds to generate yaml and commit that.
That should avoid potential errors (like in the screenshot above) and remove the dependency on kustomize for installing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xunzhuo I've updated the docs to simplify things (no kustomize or docker run needed) by referencing bundle yaml files.
This should also fix the error you were seeing.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #1871 (cfcffeb) into main (2e6211a) will increase coverage by 0.04%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1871      +/-   ##
==========================================
+ Coverage   65.31%   65.36%   +0.04%     
==========================================
  Files          86       86              
  Lines       12526    12526              
==========================================
+ Hits         8181     8187       +6     
+ Misses       3827     3822       -5     
+ Partials      518      517       -1     

see 2 files with indirect coverage changes

Signed-off-by: David Martin <davmarti@redhat.com>
@david-martin david-martin force-pushed the gateway-api-state-metrics-guide branch from 0ffc6c2 to cfcffeb Compare September 8, 2023 15:39
@arkodg arkodg requested a review from zirain September 11, 2023 18:24
@Xunzhuo Xunzhuo merged commit 31ea531 into envoyproxy:main Sep 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate david-martin / gateway-api-state-metrics in docs
3 participants