Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci-lint to 1.54.2 #1878

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Bump golangci-lint to 1.54.2 #1878

merged 5 commits into from
Sep 14, 2023

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Sep 12, 2023

fixes: #1874

@zirain
upgrade golangci-lint
df7b929 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain
fix "Implicit memory aliasing in for loop"
0111454 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner September 12, 2023 02:00
@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Merging #1878 (01f08af) into main (8e3ad25) will decrease coverage by 0.02%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
- Coverage   65.98%   65.97%   -0.02%     
==========================================
  Files          86       86              
  Lines       12910    12917       +7     
==========================================
+ Hits         8519     8522       +3     
- Misses       3851     3857       +6     
+ Partials      540      538       -2
Files Changed Coverage Δ
internal/gatewayapi/runner/runner.go 24.07% <0.00%> (-1.42%) ⬇️
internal/xds/translator/jsonpatch.go 31.15% <100.00%> (+0.34%) ⬆️

... and 2 files with indirect coverage changes

@zirain
Copy link
Contributor Author

zirain commented Sep 12, 2023

/retest

@arkodg arkodg mentioned this pull request Sep 12, 2023
Closed
@zirain
update
13de767 
Signed-off-by: zirain <zirain2009@gmail.com>
Xunzhuo
Xunzhuo reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit about why these x := x lines? They are just Shallow Copy I think.

@zirain
Copy link
Contributor Author

zirain commented Sep 13, 2023

see https://stackoverflow.com/questions/62446118/implicit-memory-aliasing-in-for-loop

@Alice-Lilith Alice-Lilith merged commit 8bfa8ab into envoyproxy:main Sep 14, 2023
17 of 18 checks passed
@zirain zirain deleted the golintci branch September 15, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xunzhuo Xunzhuo Xunzhuo left review comments

@Alice-Lilith Alice-Lilith Alice-Lilith approved these changes

@arkodg arkodg arkodg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zirain @arkodg @Alice-Lilith @Xunzhuo