Delete gateway api admission server #1890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer required, Gateway API has transitioned to CEL based validation https://kubernetes.io/blog/2023/08/29/gateway-api-v0-8/#cel-validation Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
force-pushed
the
rm-admission-server
branch
from
1a5964b to
e8f182d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1890 +/- ##
==========================================
+ Coverage 66.07% 66.14% +0.06%
==========================================
Files 86 86
Lines 12874 12874
==========================================
+ Hits 8507 8516 +9
+ Misses 3838 3830 -8
+ Partials 529 528 -1 |
|
looks like we cannot manually omit the admission server resource since our tooling relies on the upstream install manifests |
|
gen-check needs fix |
|
kubernetes-sigs/gateway-api#2400 has been fixed upstream, nothing needs to be done in this PR since the omission of the webhook resources is handled in upstream itself, so we'll auto fix this the next time we bump to gateway-api v1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer required, Gateway API has transitioned to
CEL based validation https://kubernetes.io/blog/2023/08/29/gateway-api-v0-8/#cel-validation