Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic control plane metrics instrumentation #1983

Closed

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Oct 17, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

After: #1982
Part of: #700

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo requested a review from a team as a code owner October 17, 2023 08:42
@Xunzhuo Xunzhuo added the area/observability Observability related issues label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1983 (de608be) into main (fa55804) will decrease coverage by 1.10%.
The diff coverage is 31.43%.

@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
- Coverage   65.53%   64.43%   -1.10%     
==========================================
  Files          92      101       +9     
  Lines       13528    13965     +437     
==========================================
+ Hits         8865     8999     +134     
- Misses       4114     4407     +293     
- Partials      549      559      +10     
Files Coverage Δ
...ternal/infrastructure/kubernetes/infra_resource.go 81.65% <100.00%> (+2.26%) ⬆️
internal/xds/translator/runner/runner.go 69.81% <100.00%> (+0.58%) ⬆️
internal/admin/server.go 56.75% <66.66%> (ø)
internal/xds/translator/extension.go 74.66% <93.75%> (+2.27%) ⬆️
internal/cmd/server.go 17.68% <0.00%> (-0.37%) ⬇️
internal/gatewayapi/runner/runner.go 22.60% <25.00%> (-0.41%) ⬇️
internal/xds/server/runner/runner.go 28.18% <0.00%> (-0.53%) ⬇️
internal/metrics/otel_label.go 25.00% <25.00%> (ø)
internal/message/watchutil.go 77.41% <70.83%> (-22.59%) ⬇️
internal/metrics/options.go 58.82% <58.82%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

@Xunzhuo Xunzhuo marked this pull request as draft October 18, 2023 08:58
@zirain
Copy link
Contributor

zirain commented Oct 26, 2023

@Xunzhuo can we close this?

@Xunzhuo Xunzhuo closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/observability Observability related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants