-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump gateway api to v1.0.0-rc1 #1987
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1987 +/- ##
=======================================
Coverage 65.66% 65.66%
=======================================
Files 92 92
Lines 13509 13509
=======================================
Hits 8871 8871
Misses 4095 4095
Partials 543 543
|
this will be part of v0.6? |
@zirain yes |
@@ -33,8 +33,8 @@ func TestE2E(t *testing.T) { | |||
client, err := client.New(cfg, client.Options{}) | |||
require.NoError(t, err) | |||
|
|||
require.NoError(t, v1alpha2.AddToScheme(client.Scheme())) | |||
require.NoError(t, v1beta1.AddToScheme(client.Scheme())) | |||
require.NoError(t, gwapiv1a2.AddToScheme(client.Scheme())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For TCPRoute, GRPCRoute, TLSRoute, UDPRoute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this's something EG must do, thanks @arkodg for all the efforts.
@envoyproxy/gateway-maintainers @envoyproxy/gateway-reviewers PTAL. |
* update all YAML resources from `v1beta1` to `v1` * update all go imports from `v1beta1` to `v1` Release details in https://github.com/kubernetes-sigs/gateway-api/releases/tag/v1.0.0-rc1 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @arkodg, for taking care of the chores.
8755b11
to
ef1c75c
Compare
v1beta1
tov1
v1beta1
tov1
Release details in https://github.com/kubernetes-sigs/gateway-api/releases/tag/v1.0.0-rc1
Since the new upstream YAML no longer add a webhook, admission controller this PR
Also fixes #1773