add GenerationChanged predicate filter to all resources #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1993 +/- ##
==========================================
- Coverage 65.51% 65.48% -0.03%
==========================================
Files 92 92
Lines 13528 13549 +21
==========================================
+ Hits 8863 8873 +10
- Misses 4116 4126 +10
- Partials 549 550 +1
|
cnvergence
force-pushed
the
add-generation-predicates
branch
from
b6f3642 to
b1680e5
Compare
|
/retest |
1 similar comment
|
/retest |
cnvergence
force-pushed
the
add-generation-predicates
branch
2 times, most recently
from
c03edd4 to
2d37706
Compare
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
cnvergence
force-pushed
the
add-generation-predicates
branch
from
2d37706 to
08cd2d3
Compare
arkodg
reviewed
Oct 18, 2023
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
arkodg
reviewed
Oct 18, 2023
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
cnvergence
force-pushed
the
add-generation-predicates
branch
from
9301d67 to
c16339a
Compare
arkodg
requested review from
a team,
kflynn,
zhaohuabing and
chauhanshubham
and removed request for
a team
zirain
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Per review of #1938 (comment), it would be valuable to add GenerationChanged predicate to all resources, except Service and Deployment.
This skip events that have no change in the object Spec and only the metadata and/or status fields are changed.