feat(helm): support annotations for certgen resources #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicco785
force-pushed
the
1-support-helm-chart-compatibility-with-argocd-via-annotations-for-jobs
branch
2 times, most recently
from
152aabd to
e46a880
Compare
zirain
reviewed
Oct 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #1996 +/- ##
==========================================
+ Coverage 65.51% 65.55% +0.03%
==========================================
Files 92 92
Lines 13528 13528
==========================================
+ Hits 8863 8868 +5
+ Misses 4116 4112 -4
+ Partials 549 548 -1 |
|
You need to run make generate to update helm docs. |
chicco785
force-pushed
the
1-support-helm-chart-compatibility-with-argocd-via-annotations-for-jobs
branch
4 times, most recently
from
a220d8c to
648b9c2
Compare
|
thx @Xunzhuo, I applied changes as per your suggestion and re-generated helm chart documentation |
arkodg
reviewed
Oct 18, 2023
arkodg
reviewed
Oct 18, 2023
arkodg
reviewed
Oct 18, 2023
* support annotations for certgen resources * support configuration for certgen job ttlSecondsAfterFinished Signed-off-by: Federico M. Facca <federico.facca@zaphiro.ch>
Signed-off-by: Federico M. Facca <federico.facca@zaphiro.ch>
Signed-off-by: Federico M. Facca <federico.facca@zaphiro.ch>
Signed-off-by: Federico M. Facca <federico.facca@zaphiro.ch>
chicco785
force-pushed
the
1-support-helm-chart-compatibility-with-argocd-via-annotations-for-jobs
branch
from
1638458 to
753b466
Compare
zirain
approved these changes
Oct 19, 2023
if you point me to an example, I am happy to give it a try :) |
Xunzhuo
approved these changes
Oct 19, 2023
chicco785
deleted the
1-support-helm-chart-compatibility-with-argocd-via-annotations-for-jobs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat(helm): support annotations for certgen resources
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1954