Revert "provider: finalize EnvoyProxy referenced by a managed GatewayClass(#1534) #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Class (envoyproxy#1534)" This reverts commit e158ef1. Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Codecov Report
@@ Coverage Diff @@
## main #2000 +/- ##
==========================================
+ Coverage 65.51% 65.59% +0.07%
==========================================
Files 92 92
Lines 13528 13488 -40
==========================================
- Hits 8863 8847 -16
+ Misses 4116 4098 -18
+ Partials 549 543 -6
|
arkodg
requested review from
a team,
qicz,
LanceEa and
Xunzhuo
and removed request for
a team
Alice-Lilith
approved these changes
Oct 18, 2023
zirain
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e158ef1.
Relates to #1999 (comment)