Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix Rate Limit All Requests by GRPCRoute in rate-limit.md #2009

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

lianghao208
Copy link
Contributor

fix Rate Limit All Requests by GRPCRoute in rate-limit.md

What type of PR is this?
fix the docs

Which issue(s) this PR fixes:

Fixes #2008

fix Rate Limit All Requests by GRPCRoute in rate-limit.md

Signed-off-by: royliang <roylizard3@gmail.com>
@lianghao208 lianghao208 requested a review from a team as a code owner October 19, 2023 04:53
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2009 (8d6a94e) into main (d3110e3) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
+ Coverage   65.66%   65.68%   +0.02%     
==========================================
  Files          92       92              
  Lines       13509    13509              
==========================================
+ Hits         8871     8874       +3     
+ Misses       4095     4093       -2     
+ Partials      543      542       -1     

see 2 files with indirect coverage changes

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg merged commit 45705b9 into envoyproxy:main Oct 19, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Rate Limit All Requests by GRPCRoute section in rate-limit doc may need to be fix
3 participants