api: proposal proxy ports #2021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zirain <zirain2009@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2021 +/- ##
==========================================
+ Coverage 65.55% 65.67% +0.11%
==========================================
Files 92 92
Lines 13509 13509
==========================================
+ Hits 8856 8872 +16
+ Misses 4107 4094 -13
+ Partials 546 543 -3 |
qicz
approved these changes
Oct 20, 2023
|
@zirain can we add this post v0.6 ? |
sure, it's not urgent. |
arkodg
reviewed
Nov 10, 2023
| // HealthCheck, Prometheus metrics. | ||
| // If unspecified, defaults to 19001. | ||
| // +optional | ||
| ExtraPort *int32 `json:"extraPort,omitempty"` |
There was a problem hiding this comment.
extraPort is not a great name imo
should we split this up into prometheusPort & healthCheckPort ?
There was a problem hiding this comment.
nop, it will/should shared one port in most cases.
There was a problem hiding this comment.
can we then come up with a better name
There was a problem hiding this comment.
do you have any good idea?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this's an alternative for #1787
xref: #1703
follow up of: #2015 (comment)