e2e: tests for TCPRoute #2109
e2e: tests for TCPRoute #2109
Conversation
slayer321
force-pushed
the
tcproute-e2e
branch
from
6a50d2a to
0d837c0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
+ Coverage 64.19% 64.22% +0.03%
==========================================
Files 107 107
Lines 14924 14924
==========================================
+ Hits 9580 9585 +5
+ Misses 4768 4764 -4
+ Partials 576 575 -1 ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| // Send a request to an valid path and expect a successful response | ||
| http.MakeRequestAndExpectEventuallyConsistentResponse(t, suite.RoundTripper, suite.TimeoutConfig, gwAddr, OkResp) |
There was a problem hiding this comment.
how is the destination port (8090, 8080) being computed ?
There was a problem hiding this comment.
As I understand following the docs. We have one Gateway resource(and two TCP listerns on port 8080 and 8090) and two TCPRoute resources. When e2e test is run gateways are created and requests are passed to the added services port for TCPRoute. (Please correct me if I'm missing something here.)
There was a problem hiding this comment.
While checking for WaitForGatewayAddress function found that it only get's the port of first listeners . In our case we have two listeners sets on (8080, 8090) , but as It is just getting the first port of the listener i.e 8080 . After running the e2e test I found that it is making request on same port for both listeners
tcp-route.go:83: Making GET request to http://172.18.255.205:8080/
tcp-route.go:102: Making GET request to http://172.18.255.205:8080/
There was a problem hiding this comment.
can you ensure traffic is sent to different ports
There was a problem hiding this comment.
Done, Now traffic is send to specific ports
tcp-route.go:78: Making GET request to http://172.18.255.205:8090/
tcp-route.go:60: Making GET request to http://172.18.255.205:8080/
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
slayer321
force-pushed
the
tcproute-e2e
branch
from
d6b5a3e to
a92a115
Compare
|
|
||
| // WaitForGatewayAddress waits until at least one IP Address has been set in the | ||
| // status of the specified Gateway. | ||
| func WaitForGatewayAddress(t *testing.T, client client.Client, timeoutConfig config.TimeoutConfig, gwName types.NamespacedName, sectionName string) (string, error) { |
There was a problem hiding this comment.
can't this be reused
https://github.com/kubernetes-sigs/gateway-api/blob/95a6b8a1f7b27bc0e632e4f44fc3e277a80276bc/conformance/utils/kubernetes/helpers.go#L394 ?
can the other helper functions be reused from upstream ?
There was a problem hiding this comment.
For TCP test we cannot use it as we are using two listeners here and as I mentioned in this comment inside the WaitForGatewayAddress function they are only checking the port for the first listeners. Here I have update the WaitForGatewayAddress function to take the sectionName and select the port based on that and if the sectionName is empty it will bydefault take the first listeners port.
can the other helper functions be reused from upstream ?
Yes, I'm mostly using all the helper function from upstream and as we already have the udp test merged I'm using some of the upstream code from there as there is no need to duplicate it .
Signed-off-by: slayer321 <sachin.maurya7666@gmail.com>
What type of PR is this?
e2e: tests for TCPRoute
What this PR does / why we need it:
Add the e2e test for TCPRoute
Which issue(s) this PR fixes:
Fixes #2010