Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add metrics instrumentations for status updater #2130

Closed
wants to merge 2 commits into from
Closed

feat: add metrics instrumentations for status updater #2130

wants to merge 2 commits into from

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented Oct 31, 2023 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

image

Fixes: #2131

@Xunzhuo Xunzhuo requested a review from a team as a code owner October 31, 2023 08:29
@Xunzhuo Xunzhuo added this to the 0.6.0 milestone Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 63.21%. Comparing base (4c79ef9) to head (58e4e75).
Report is 225 commits behind head on main.

Files Patch % Lines
internal/status/status.go 0.00% 51 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2130      +/-   ##
==========================================
- Coverage   63.38%   63.21%   -0.18%     
==========================================
  Files         119      119              
  Lines       19098    19145      +47     
==========================================
- Hits        12106    12102       -4     
- Misses       6193     6243      +50     
- Partials      799      800       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xunzhuo Xunzhuo force-pushed the feat-status-metrics branch 2 times, most recently from e7c1bd6 to 3fc9ff7 Compare October 31, 2023 08:48
@Xunzhuo Xunzhuo requested review from a team, LanceEa, tmsnan and shawnh2 and removed request for a team October 31, 2023 08:49
@Xunzhuo Xunzhuo requested review from qicz and zirain October 31, 2023 08:50
@Xunzhuo Xunzhuo force-pushed the feat-status-metrics branch from 3fc9ff7 to fb79a54 Compare October 31, 2023 10:48
@Xunzhuo Xunzhuo added the area/observability Observability related issues label Oct 31, 2023
@arkodg
Copy link
Contributor

arkodg commented Oct 31, 2023

thanks for adding this @Xunzhuo, will review post the v0.6 release

@zirain zirain modified the milestones: 0.6.0, Backlog Oct 31, 2023
@Xunzhuo
feat: add metrics instrumentations for status updater
63f2797 
Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo force-pushed the feat-status-metrics branch from fb79a54 to 63f2797 Compare November 1, 2023 03:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 1, 2023
@Xunzhuo Xunzhuo modified the milestones: Backlog, v1.0.0-rc1 Dec 6, 2023
@github-actions github-actions bot removed the stale label Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added stale and removed stale labels Jan 5, 2024
@arkodg
Copy link
Contributor

arkodg commented Jan 5, 2024

hey @Xunzhuo is this ready for a review ?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added stale and removed stale labels Feb 5, 2024
@Xunzhuo Xunzhuo modified the milestones: v1.0.0-rc1, Backlog Mar 1, 2024
@Xunzhuo Xunzhuo marked this pull request as draft March 1, 2024 07:51
@Xunzhuo
Copy link
Member Author

Xunzhuo commented Mar 1, 2024

Move this to Backlog.

@arkodg arkodg removed the road-to-ga label Mar 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Apr 1, 2024
@shawnh2 shawnh2 self-assigned this May 7, 2024
@shawnh2 shawnh2 mentioned this pull request May 7, 2024
Closed
@github-actions github-actions bot removed the stale label May 7, 2024
@shawnh2 shawnh2 mentioned this pull request May 8, 2024
Merged
@guydc guydc closed this in #3347 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LanceEa LanceEa Awaiting requested review from LanceEa LanceEa was automatically assigned from envoyproxy/gateway-reviewers

@tmsnan tmsnan Awaiting requested review from tmsnan tmsnan was automatically assigned from envoyproxy/gateway-reviewers

@shawnh2 shawnh2 Awaiting requested review from shawnh2 shawnh2 was automatically assigned from envoyproxy/gateway-reviewers

@qicz qicz Awaiting requested review from qicz

@zirain zirain Awaiting requested review from zirain

Assignees

@shawnh2 shawnh2

Labels
area/observability Observability related issues
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Implement Metrics instrumentation for Status Updater
5 participants
@Xunzhuo @arkodg @zhaohuabing @zirain @shawnh2