Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E Tests for UDPRoute #2140

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Add E2E Tests for UDPRoute #2140

merged 4 commits into from
Nov 15, 2023

Conversation

cnvergence
Copy link
Member

@cnvergence cnvergence commented Oct 31, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2011

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #2140 (2e604f8) into main (a0505b9) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2140      +/-   ##
==========================================
- Coverage   64.30%   64.15%   -0.16%     
==========================================
  Files         107      107              
  Lines       14665    14665              
==========================================
- Hits         9431     9409      -22     
- Misses       4667     4685      +18     
- Partials      567      571       +4     

see 2 files with indirect coverage changes

@cnvergence cnvergence marked this pull request as ready for review November 2, 2023 12:47
@cnvergence cnvergence requested a review from a team as a code owner November 2, 2023 12:47
test/e2e/tests/udproute.go Outdated Show resolved Hide resolved
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team, qicz, Alice-Lilith and chauhanshubham and removed request for a team November 14, 2023 22:21
@zirain zirain merged commit 112d3c3 into envoyproxy:main Nov 15, 2023
18 checks passed
@cnvergence cnvergence deleted the udproute-e2e branch December 12, 2023 08:54
@shawnh2 shawnh2 mentioned this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E Tests for UDPRoute
3 participants