-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use go standard errors #2382
Merged
Merged
use go standard errors #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2382 +/- ##
==========================================
- Coverage 64.64% 64.62% -0.02%
==========================================
Files 114 114
Lines 16618 16618
==========================================
- Hits 10742 10740 -2
- Misses 5197 5199 +2
Partials 679 679 ☔ View full report in Codecov by Sentry. |
mmorel-35
force-pushed
the
errorlint
branch
7 times, most recently
from
December 30, 2023 11:38
168b9c1
to
b580d7e
Compare
zirain
previously approved these changes
Dec 31, 2023
zhaohuabing
previously approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
The conflicts are resolved now |
zhaohuabing
approved these changes
Jan 2, 2024
zirain
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
github.com/pkg/errors is not maintained and can be replaced by go standard errors
Which issue(s) this PR fixes: