Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go standard errors #2382

Merged
merged 1 commit into from
Jan 2, 2024
Merged

use go standard errors #2382

merged 1 commit into from
Jan 2, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 30, 2023

What type of PR is this?

  • chore: use go standard errors and enable errorlint

What this PR does / why we need it:
github.com/pkg/errors is not maintained and can be replaced by go standard errors

Which issue(s) this PR fixes:

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (6268983) 64.64% compared to head (229e234) 64.62%.

Files Patch % Lines
internal/provider/kubernetes/controller.go 8.33% 11 Missing ⚠️
internal/infrastructure/kubernetes/infra.go 10.00% 9 Missing ⚠️
internal/xds/translator/jsonpatch.go 0.00% 8 Missing ⚠️
internal/cmd/egctl/envoy_stats.go 0.00% 6 Missing ⚠️
internal/provider/kubernetes/routes.go 0.00% 5 Missing ⚠️
internal/cmd/certgen.go 0.00% 4 Missing ⚠️
internal/infrastructure/kubernetes/infra_client.go 0.00% 2 Missing ⚠️
internal/provider/kubernetes/filters.go 0.00% 2 Missing ⚠️
internal/xds/translator/tracing.go 0.00% 2 Missing ⚠️
internal/cmd/egctl/version.go 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2382      +/-   ##
==========================================
- Coverage   64.64%   64.62%   -0.02%     
==========================================
  Files         114      114              
  Lines       16618    16618              
==========================================
- Hits        10742    10740       -2     
- Misses       5197     5199       +2     
  Partials      679      679              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the errorlint branch 7 times, most recently from 168b9c1 to b580d7e Compare December 30, 2023 11:38
@mmorel-35 mmorel-35 marked this pull request as ready for review December 30, 2023 11:42
@mmorel-35 mmorel-35 requested a review from a team as a code owner December 30, 2023 11:42
zirain
zirain previously approved these changes Dec 31, 2023
zhaohuabing
zhaohuabing previously approved these changes Jan 2, 2024
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Contributor Author

The conflicts are resolved now

@zirain zirain merged commit b935d77 into envoyproxy:main Jan 2, 2024
14 of 15 checks passed
@mmorel-35 mmorel-35 deleted the errorlint branch January 2, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants