chore: enable testifylint linter #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
zirain
previously approved these changes
Jan 12, 2024
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2436 +/- ##
==========================================
- Coverage 64.72% 64.67% -0.06%
==========================================
Files 115 115
Lines 17402 17402
==========================================
- Hits 11264 11254 -10
- Misses 5424 5432 +8
- Partials 714 716 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
zirain
approved these changes
Jan 12, 2024
shawnh2
approved these changes
Jan 13, 2024
zesiar0
pushed a commit
to zesiar0/gateway
that referenced
this pull request
Jan 22, 2024
* Update .golangci.yml Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update .golangci.yml Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update .golangci.yml Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update experimental_conformance_test.go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: A3bz <zeng921359373@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This linter helps ensuring the best practices for testify are being applied.
Which issue(s) this PR fixes: