Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: downstream client CACert validation #2483

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Jan 22, 2024

Relates to #88

@arkodg arkodg requested a review from a team as a code owner January 22, 2024 22:45
zirain
zirain previously approved these changes Jan 23, 2024
Copy link
Member

@zirain zirain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zhaohuabing
zhaohuabing previously approved these changes Jan 23, 2024
@arkodg arkodg dismissed stale reviews from zhaohuabing and zirain via 7d4b2fd January 23, 2024 01:33
Relates to envoyproxy#88

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2b62b2) 64.66% compared to head (03c0a80) 64.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2483      +/-   ##
==========================================
+ Coverage   64.66%   64.68%   +0.02%     
==========================================
  Files         115      115              
  Lines       17465    17465              
==========================================
+ Hits        11293    11298       +5     
+ Misses       5449     5447       -2     
+ Partials      723      720       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested review from zhaohuabing and zirain January 23, 2024 02:20
@zhaohuabing zhaohuabing merged commit 9b6e45e into envoyproxy:main Jan 23, 2024
20 checks passed
@arkodg arkodg deleted the downstream-mtls branch January 23, 2024 02:37
soulxu pushed a commit to soulxu/gateway that referenced this pull request Jan 23, 2024
* api: downstream client CACert validation

Relates to envoyproxy#88

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* docs

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* charts

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit to arkodg/gateway that referenced this pull request Jan 23, 2024
Relates to envoyproxy#2483

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg mentioned this pull request Jan 23, 2024
arkodg added a commit to arkodg/gateway that referenced this pull request Jan 30, 2024
Relates to envoyproxy#2483

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit to arkodg/gateway that referenced this pull request Feb 10, 2024
Relates to envoyproxy#2483

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg added a commit that referenced this pull request Feb 14, 2024
* feat: downstream mTLS

Relates to #2483

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* configmap provider logic

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* gatewayapi translation

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix charts

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* tests

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
yaelSchechter pushed a commit to yaelSchechter/envoy-gateway that referenced this pull request Feb 14, 2024
* feat: downstream mTLS

Relates to envoyproxy#2483

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* configmap provider logic

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* gatewayapi translation

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix charts

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* tests

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
vixns pushed a commit to vixns/gateway that referenced this pull request Feb 18, 2024
* feat: downstream mTLS

Relates to envoyproxy#2483

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* configmap provider logic

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* gatewayapi translation

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix charts

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* tests

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Stéphane Cottin <stephane.cottin@vixns.com>
zirain added a commit that referenced this pull request Feb 18, 2024
* feat: Suppress 'X-Envoy' headers and pass-through the upstream 'Server' header by default (#2585)

* Implement and update tests for the default header transformations.

Signed-off-by: Lior Okman <lior.okman@sap.com>

* Make 'gen-check' happy

Signed-off-by: Lior Okman <lior.okman@sap.com>

---------

Signed-off-by: Lior Okman <lior.okman@sap.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* bug: fix merge race (#2604)

Between #2585
&
#2581

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* feat: downstream mTLS (#2490)

* feat: downstream mTLS

Relates to #2483

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* configmap provider logic

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* gatewayapi translation

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix charts

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* tests

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* lint

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

---------

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* add timeout to clientTrafficPolicy

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix comment

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* add omitempty

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* add cel test for coverage

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* run make commands

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* change request timeout field name and desc

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* tidy up comment

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix cel test

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* fix typo

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

* run generate

Signed-off-by: Yael Shechter <yael.shechter@sap.com>

---------

Signed-off-by: Lior Okman <lior.okman@sap.com>
Signed-off-by: Yael Shechter <yael.shechter@sap.com>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Co-authored-by: Lior Okman <lior.okman@sap.com>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Co-authored-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants