Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: support release channel #2549

Closed
wants to merge 1 commit into from
Closed

api: support release channel #2549

wants to merge 1 commit into from

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Feb 1, 2024

fix: #2541

@zirain
api: support release channel
26445b8 
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner February 1, 2024 05:53
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.60%. Comparing base (464fed9) to head (26445b8).
Report is 134 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2549      +/-   ##
==========================================
- Coverage   64.61%   64.60%   -0.02%     
==========================================
  Files         116      116              
  Lines       17809    17809              
==========================================
- Hits        11508    11505       -3     
- Misses       5564     5567       +3     
  Partials      737      737

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cnvergence
cnvergence approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@cnvergence cnvergence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Xunzhuo
Copy link
Member

Xunzhuo commented Feb 4, 2024

Should other policies be included as experimental too ?

@zirain
Copy link
Contributor Author

zirain commented Feb 4, 2024

Should other policies be included as experimental too ?

wait for decision #2541

@arkodg arkodg mentioned this pull request Feb 8, 2024
Closed
@zirain zirain mentioned this pull request Feb 22, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added stale and removed stale labels Mar 5, 2024
@zirain
Copy link
Contributor Author

zirain commented Mar 10, 2024

kindly ping @arkodg on this

@zhaohuabing
Copy link
Member

Are release channels and API versions related? For example, could EG have an Experiment channel containing V1 API?

@zirain
Copy link
Contributor Author

zirain commented Apr 1, 2024

No longer need this

@zirain zirain closed this Apr 1, 2024
@zirain zirain deleted the release-channel branch October 18, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnvergence cnvergence cnvergence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mark all extension API fields as experimental
4 participants
@zirain @Xunzhuo @zhaohuabing @cnvergence