Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add all resource type support for egctl x status #2573

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Feb 7, 2024

What type of PR is this?

follow-up of #2550, add support for egctl x status all to get the summary of all resource types status

for example, the resource types with empty status will be ignored:

image

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner February 7, 2024 13:22
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (4c79ef9) 63.38% compared to head (209b6f5) 63.34%.

Files Patch % Lines
internal/cmd/egctl/status.go 43.18% 46 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2573      +/-   ##
==========================================
- Coverage   63.38%   63.34%   -0.05%     
==========================================
  Files         119      119              
  Lines       19098    19139      +41     
==========================================
+ Hits        12106    12124      +18     
- Misses       6193     6216      +23     
  Partials      799      799              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg
Copy link
Contributor

arkodg commented Feb 7, 2024

can we keep this similar to kubectl get all which looks like

the resource type is appended into the name with /

kubectl get all
NAME                           READY   STATUS    RESTARTS       AGE
pod/backend-5cbb9cd947-rgdb7   1/1     Running   2 (116m ago)   2d3h

NAME                 TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)    AGE
service/backend      ClusterIP   10.97.147.91   <none>        3000/TCP   2d3h
service/kubernetes   ClusterIP   10.96.0.1      <none>        443/TCP    2d3h

NAME                      READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/backend   1/1     1            1           2d3h

NAME                                 DESIRED   CURRENT   READY   AGE
replicaset.apps/backend-5cbb9cd947   1         1         1       2d3h
``

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2
Copy link
Contributor Author

shawnh2 commented Feb 9, 2024

can we keep this similar to kubectl get all which looks like

the resource type is appended into the name with /

kubectl get all
NAME                           READY   STATUS    RESTARTS       AGE
pod/backend-5cbb9cd947-rgdb7   1/1     Running   2 (116m ago)   2d3h

NAME                 TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)    AGE
service/backend      ClusterIP   10.97.147.91   <none>        3000/TCP   2d3h
service/kubernetes   ClusterIP   10.96.0.1      <none>        443/TCP    2d3h

NAME                      READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/backend   1/1     1            1           2d3h

NAME                                 DESIRED   CURRENT   READY   AGE
replicaset.apps/backend-5cbb9cd947   1         1         1       2d3h
``

done, it's much simpler this way.

image

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@arkodg
Copy link
Contributor

arkodg commented Feb 9, 2024

great work @shawnh2, one suggestion - can we use small case for kind ?

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 force-pushed the support-egctl-x-status-all branch from 3aca2ce to af15847 Compare February 10, 2024 05:48
@shawnh2
Copy link
Contributor Author

shawnh2 commented Feb 10, 2024

great work @shawnh2, one suggestion - can we use small case for kind ?

of course

@shawnh2
Copy link
Contributor Author

shawnh2 commented Feb 10, 2024

/retest

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team February 13, 2024 21:43
Copy link
Member

@cnvergence cnvergence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shawnh2
Copy link
Contributor Author

shawnh2 commented Feb 22, 2024

/retest

@arkodg arkodg merged commit 5a0baf0 into envoyproxy:main Feb 22, 2024
19 of 20 checks passed
@shawnh2 shawnh2 deleted the support-egctl-x-status-all branch February 23, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants