-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add all resource type support for egctl x status
#2573
Conversation
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2573 +/- ##
==========================================
- Coverage 63.38% 63.34% -0.05%
==========================================
Files 119 119
Lines 19098 19139 +41
==========================================
+ Hits 12106 12124 +18
- Misses 6193 6216 +23
Partials 799 799 ☔ View full report in Codecov by Sentry. |
can we keep this similar to the resource type is appended into the name with
|
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
great work @shawnh2, one suggestion - can we use small case for |
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
3aca2ce
to
af15847
Compare
of course |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/retest |
What type of PR is this?
follow-up of #2550, add support for
egctl x status all
to get the summary of all resource types statusfor example, the resource types with empty status will be ignored: