add a catch-all route if needed #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
==========================================
+ Coverage 63.41% 63.57% +0.16%
==========================================
Files 119 119
Lines 19163 19198 +35
==========================================
+ Hits 12152 12206 +54
+ Misses 6196 6180 -16
+ Partials 815 812 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
catch-all-route
branch
from
6617e4f to
1c33498
Compare
arkodg
reviewed
Feb 12, 2024
| // For filters without native per-route support, we need to add a catch-all route | ||
| // to ensure that these filters are disabled for non-matching requests. | ||
| // https://github.com/envoyproxy/gateway/issues/2507 | ||
| func addCatchAllRoute(xdsIR map[string]*ir.Xds) { |
arkodg
reviewed
Feb 12, 2024
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
arkodg
reviewed
Feb 14, 2024
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
zhaohuabing
force-pushed
the
catch-all-route
branch
from
82b4268 to
4a2cdbe
Compare
arkodg
reviewed
Feb 14, 2024
arkodg
reviewed
Feb 14, 2024
arkodg
added a commit
to arkodg/gateway
that referenced
this pull request
Feb 14, 2024
Add a field called `useForRouting` that signals to Envoy Gateway that the headers generated from the claims are used to make routing decisions Internally this field will be used to * insert a catch-all route with a 404 direct response identical to envoyproxy#2586 which makes sure the jwt filter with `claimToHeader` is applied before recomputing routing decision * enable `clear_route_cache` to recompute routing decision https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/jwt_authn/v3/config.proto#extensions-filters-http-jwt-authn-v3-jwtprovider Relates to envoyproxy#2452 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com>
Signed-off-by: huabing zhao <zhaohuabing@gmail.com>
arkodg
approved these changes
Feb 15, 2024
vixns
pushed a commit
to vixns/gateway
that referenced
this pull request
Feb 18, 2024
* add a catch-all route if needed Signed-off-by: huabing zhao <zhaohuabing@gmail.com> * fix lint and gen Signed-off-by: huabing zhao <zhaohuabing@gmail.com> * make catch all route name unique across mulitple hosts Signed-off-by: huabing zhao <zhaohuabing@gmail.com> * Update internal/gatewayapi/translator.go Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> * address comments Signed-off-by: huabing zhao <zhaohuabing@gmail.com> --------- Signed-off-by: huabing zhao <zhaohuabing@gmail.com> Signed-off-by: Huabing Zhao <zhaohuabing@gmail.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Stéphane Cottin <stephane.cottin@vixns.com>
zhaohuabing
added a commit
to zhaohuabing/gateway
that referenced
this pull request
Feb 20, 2024
This reverts commit 35e646d.
arkodg
added a commit
to arkodg/gateway
that referenced
this pull request
Feb 20, 2024
Add a field called `useForRouting` that signals to Envoy Gateway that the headers generated from the claims are used to make routing decisions Internally this field will be used to * insert a catch-all route with a 404 direct response identical to envoyproxy#2586 which makes sure the jwt filter with `claimToHeader` is applied before recomputing routing decision * enable `clear_route_cache` to recompute routing decision https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/jwt_authn/v3/config.proto#extensions-filters-http-jwt-authn-v3-jwtprovider Relates to envoyproxy#2452 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
arkodg
added a commit
to arkodg/gateway
that referenced
this pull request
Feb 23, 2024
Add a field called `useForRouting` that signals to Envoy Gateway that the headers generated from the claims are used to make routing decisions Internally this field will be used to * insert a catch-all route with a 404 direct response identical to envoyproxy#2586 which makes sure the jwt filter with `claimToHeader` is applied before recomputing routing decision * enable `clear_route_cache` to recompute routing decision https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/jwt_authn/v3/config.proto#extensions-filters-http-jwt-authn-v3-jwtprovider Relates to envoyproxy#2452 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2507