Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix failed test case introduced by #2490 #2608

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Feb 14, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2490 test case

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 224 lines in your changes are missing coverage. Please review.

Comparison is base (446997b) 63.89% compared to head (e92561a) 63.38%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/provider/kubernetes/controller.go 22.52% 83 Missing and 3 partials ⚠️
internal/provider/kubernetes/indexers.go 5.00% 36 Missing and 2 partials ⚠️
internal/gatewayapi/clienttrafficpolicy.go 66.66% 15 Missing and 5 partials ⚠️
internal/gatewayapi/validate.go 58.33% 14 Missing and 6 partials ⚠️
internal/ir/zz_generated.deepcopy.go 0.00% 18 Missing and 1 partial ⚠️
internal/provider/kubernetes/predicates.go 58.06% 10 Missing and 3 partials ⚠️
internal/gatewayapi/zz_generated.deepcopy.go 0.00% 9 Missing ⚠️
internal/xds/translator/listener.go 70.00% 8 Missing and 1 partial ⚠️
internal/xds/translator/translator.go 33.33% 6 Missing and 2 partials ⚠️
internal/gatewayapi/resource.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2608      +/-   ##
==========================================
- Coverage   63.89%   63.38%   -0.51%     
==========================================
  Files         119      119              
  Lines       18847    19163     +316     
==========================================
+ Hits        12042    12147     +105     
- Misses       6010     6200     +190     
- Partials      795      816      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg merged commit b97e5ab into envoyproxy:main Feb 14, 2024
16 of 17 checks passed
@arkodg
Copy link
Contributor

arkodg commented Feb 14, 2024

thanks @shawnh2 for taking care of this, I should have rebased

@shawnh2 shawnh2 deleted the fix-broken-ci branch February 15, 2024 00:04
vixns pushed a commit to vixns/gateway that referenced this pull request Feb 18, 2024
…#2608)

fix mtls failed test

Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: Stéphane Cottin <stephane.cottin@vixns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants