chore: remove invalid multiple GatewayClass e2e test #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2655 +/- ##
=======================================
Coverage 63.41% 63.41%
=======================================
Files 119 119
Lines 19227 19227
=======================================
Hits 12193 12193
Misses 6222 6222
Partials 812 812 ☔ View full report in Codecov by Sentry. |
shawnh2
approved these changes
Feb 19, 2024
arkodg
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
As pointed out in the issue #2636, even when applying gateways from yaml files, the gatewayClassName will be overwritten with the set GatewayClass in the GW API conformance test suite.
Which issue(s) this PR fixes:
Part of