Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(translator): implement timeout in ClientTrafficPolicy #2667
feat(translator): implement timeout in ClientTrafficPolicy #2667
Changes from 4 commits
75ca8ce
501b262
366d4bf
f46ea5a
1087f85
a71aadd
67e13ef
bfd489a
fc14517
d1cd4bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 330 in internal/gatewayapi/clienttrafficpolicy.go
Codecov / codecov/patch
internal/gatewayapi/clienttrafficpolicy.go#L329-L330
Check warning on line 413 in internal/gatewayapi/clienttrafficpolicy.go
Codecov / codecov/patch
internal/gatewayapi/clienttrafficpolicy.go#L412-L413
Check failure on line 1 in internal/gatewayapi/testdata/clienttrafficpolicy-timeout.in.yaml
GitHub Actions / lint
Check failure on line 1 in internal/gatewayapi/testdata/clienttrafficpolicy-timeout.in.yaml
GitHub Actions / lint
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check failure on line 1 in internal/xds/translator/testdata/in/xds-ir/client-timeout.yaml
GitHub Actions / lint
Check failure on line 1 in internal/xds/translator/testdata/in/xds-ir/client-timeout.yaml
GitHub Actions / lint
Check failure on line 16 in internal/xds/translator/testdata/in/xds-ir/client-timeout.yaml
GitHub Actions / lint
Check failure on line 16 in internal/xds/translator/testdata/in/xds-ir/client-timeout.yaml
GitHub Actions / lint
Check failure on line 17 in internal/xds/translator/testdata/in/xds-ir/client-timeout.yaml
GitHub Actions / lint
Check failure on line 17 in internal/xds/translator/testdata/in/xds-ir/client-timeout.yaml
GitHub Actions / lint