Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add egctl experimental dashboard envoy-proxy to render the admin dashboard for the proxy #2669

Merged
merged 3 commits into from
Feb 24, 2024

Conversation

hanxiaop
Copy link
Contributor

What type of PR is this?

/feature

What this PR does / why we need it:

Render the admin dashboard for the proxy, to see things like configdumps without extra steps.

@hanxiaop hanxiaop requested a review from a team as a code owner February 22, 2024 02:48
@hanxiaop
Copy link
Contributor Author

Sample cmd out:

 ./egctl x dashboard envoy-proxy -n envoy-gateway-system envoy-engw-eg-a9c23fbb-558f94486c-82wh4
http://localhost:19000

Signed-off-by: xiaopeng <hanxiaop8@outlook.com>
egctl Outdated Show resolved Hide resolved
Signed-off-by: xiaopeng <hanxiaop8@outlook.com>
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 110 lines in your changes are missing coverage. Please review.

Project coverage is 63.00%. Comparing base (4c79ef9) to head (8bc249f).
Report is 7 commits behind head on main.

Files Patch % Lines
internal/cmd/egctl/envoy_dashboard.go 0.00% 98 Missing ⚠️
internal/cmd/egctl/dashboard.go 0.00% 11 Missing ⚠️
internal/cmd/egctl/experimental.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2669      +/-   ##
==========================================
- Coverage   63.38%   63.00%   -0.39%     
==========================================
  Files         119      121       +2     
  Lines       19098    19574     +476     
==========================================
+ Hits        12106    12332     +226     
- Misses       6193     6441     +248     
- Partials      799      801       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/cmd/egctl/envoy_dashboard.go Outdated Show resolved Hide resolved
internal/cmd/egctl/envoy_dashboard.go Show resolved Hide resolved
internal/cmd/egctl/envoy_dashboard.go Show resolved Hide resolved
Signed-off-by: xiaopeng <hanxiaop8@outlook.com>
@hanxiaop
Copy link
Contributor Author

@shawnh2 Thank you for the review! I think I have addressed all the comments.

@arkodg arkodg requested review from zirain and shawnh2 February 23, 2024 20:37
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@zirain zirain merged commit 5bfcb20 into envoyproxy:main Feb 24, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants