fix: fix translation of MaxRequestsPerConnection #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guy Daich <guy.daich@sap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2687 +/- ##
==========================================
+ Coverage 63.43% 63.45% +0.01%
==========================================
Files 119 119
Lines 19477 19484 +7
==========================================
+ Hits 12356 12363 +7
Misses 6323 6323
Partials 798 798 ☔ View full report in Codecov by Sentry. |
arkodg
previously approved these changes
Feb 23, 2024
Signed-off-by: Guy Daich <guy.daich@sap.com>
arkodg
approved these changes
Feb 24, 2024
shawnh2
approved these changes
Feb 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Translation from API to IR was originally omitted from the implementation: #2508
Fix translation and tests.