Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add crd categories #2713

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore: add crd categories #2713

merged 1 commit into from
Feb 27, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Feb 27, 2024

with this patch, you can get all eg resources with following command:

kubctl get envoy-gateway

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from a team as a code owner February 27, 2024 15:52
Copy link
Contributor

@liorokman liorokman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add the gateway-api category?

@zirain
Copy link
Contributor Author

zirain commented Feb 27, 2024

Maybe also add the gateway-api category?

I think we should different with upstream.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.23%. Comparing base (288cd9a) to head (980eebc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2713   +/-   ##
=======================================
  Coverage   63.23%   63.23%           
=======================================
  Files         123      123           
  Lines       19922    19922           
=======================================
  Hits        12598    12598           
  Misses       6513     6513           
  Partials      811      811           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@liorokman liorokman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arkodg arkodg merged commit efedbd1 into envoyproxy:main Feb 27, 2024
18 of 19 checks passed
zirain added a commit to zirain/gateway that referenced this pull request Feb 28, 2024
add crd categories

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain deleted the categories branch February 28, 2024 01:38
zirain added a commit to zirain/gateway that referenced this pull request Feb 28, 2024
add crd categories

Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants